mirror of
https://github.com/minetest-mods/mesecons.git
synced 2024-12-25 18:00:19 +01:00
Noteblock: Code cleanup
This commit is contained in:
parent
eab09b9d73
commit
0ec503f32c
@ -1,21 +1,15 @@
|
|||||||
minetest.register_node("mesecons_noteblock:noteblock", {
|
minetest.register_node("mesecons_noteblock:noteblock", {
|
||||||
description = "Noteblock",
|
description = "Noteblock",
|
||||||
tiles = {"mesecons_noteblock.png"},
|
tiles = {"mesecons_noteblock.png"},
|
||||||
groups = {snappy=2,choppy=2,oddly_breakable_by_hand=2},
|
groups = {snappy=2, choppy=2, oddly_breakable_by_hand=2},
|
||||||
visual_scale = 1.3,
|
on_punch = function(pos, node) -- change sound when punched
|
||||||
paramtype="light",
|
node.param2 = (node.param2+1)%12
|
||||||
after_place_node = function(pos)
|
mesecon.noteblock_play(pos, node.param2)
|
||||||
minetest.add_node(pos, {name="mesecons_noteblock:noteblock", param2=0})
|
minetest.add_node(pos, node)
|
||||||
end,
|
|
||||||
on_punch = function (pos, node) -- change sound when punched
|
|
||||||
local param2 = node.param2+1
|
|
||||||
if param2==12 then param2=0 end
|
|
||||||
minetest.add_node(pos, {name = node.name, param2 = param2})
|
|
||||||
mesecon.noteblock_play(pos, param2)
|
|
||||||
end,
|
end,
|
||||||
sounds = default.node_sound_wood_defaults(),
|
sounds = default.node_sound_wood_defaults(),
|
||||||
mesecons = {effector = { -- play sound when activated
|
mesecons = {effector = { -- play sound when activated
|
||||||
action_on = function (pos, node)
|
action_on = function(pos, node)
|
||||||
mesecon.noteblock_play(pos, node.param2)
|
mesecon.noteblock_play(pos, node.param2)
|
||||||
end
|
end
|
||||||
}}
|
}}
|
||||||
@ -30,58 +24,46 @@ minetest.register_craft({
|
|||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
mesecon.noteblock_play = function (pos, param2)
|
local soundnames = {
|
||||||
local soundname
|
[0] = "mesecons_noteblock_csharp",
|
||||||
if param2==8 then
|
"mesecons_noteblock_d",
|
||||||
soundname="mesecons_noteblock_a"
|
"mesecons_noteblock_dsharp",
|
||||||
elseif param2==9 then
|
"mesecons_noteblock_e",
|
||||||
soundname="mesecons_noteblock_asharp"
|
"mesecons_noteblock_f",
|
||||||
elseif param2==10 then
|
"mesecons_noteblock_fsharp",
|
||||||
soundname="mesecons_noteblock_b"
|
"mesecons_noteblock_g",
|
||||||
elseif param2==11 then
|
"mesecons_noteblock_gsharp",
|
||||||
soundname="mesecons_noteblock_c"
|
|
||||||
elseif param2==0 then
|
"mesecons_noteblock_a",
|
||||||
soundname="mesecons_noteblock_csharp"
|
"mesecons_noteblock_asharp",
|
||||||
elseif param2==1 then
|
"mesecons_noteblock_b",
|
||||||
soundname="mesecons_noteblock_d"
|
"mesecons_noteblock_c"
|
||||||
elseif param2==2 then
|
}
|
||||||
soundname="mesecons_noteblock_dsharp"
|
|
||||||
elseif param2==3 then
|
local node_sounds = {
|
||||||
soundname="mesecons_noteblock_e"
|
["default:glass"] = "mesecons_noteblock_hihat",
|
||||||
elseif param2==4 then
|
["default:stone"] = "mesecons_noteblock_kick",
|
||||||
soundname="mesecons_noteblock_f"
|
["default:lava_source"] = "fire_large",
|
||||||
elseif param2==5 then
|
["default:chest"] = "mesecons_noteblock_snare",
|
||||||
soundname="mesecons_noteblock_fsharp"
|
["default:tree"] = "mesecons_noteblock_crash",
|
||||||
elseif param2==6 then
|
["default:wood"] = "mesecons_noteblock_litecrash",
|
||||||
soundname="mesecons_noteblock_g"
|
["default:coalblock"] = "tnt_explode",
|
||||||
elseif param2==7 then
|
}
|
||||||
soundname="mesecons_noteblock_gsharp"
|
|
||||||
|
mesecon.noteblock_play = function(pos, param2)
|
||||||
|
pos.y = pos.y-1
|
||||||
|
local nodeunder = minetest.get_node(pos).name
|
||||||
|
local soundname = node_sounds[nodeunder]
|
||||||
|
if not soundname then
|
||||||
|
soundname = soundnames[param2]
|
||||||
|
if not soundname then
|
||||||
|
minetest.log("error", "[mesecons_noteblock] No soundname found, test param2")
|
||||||
|
return
|
||||||
end
|
end
|
||||||
local block_below_name = minetest.get_node({x=pos.x, y=pos.y-1, z=pos.z}).name
|
if nodeunder == "default:steelblock" then
|
||||||
if block_below_name == "default:glass" then
|
soundname = soundname.. 2
|
||||||
soundname="mesecons_noteblock_hihat"
|
|
||||||
end
|
end
|
||||||
if block_below_name == "default:steelblock" then
|
|
||||||
soundname=soundname.."2" -- Go up an octave.
|
|
||||||
end
|
end
|
||||||
if block_below_name == "default:stone" then
|
pos.y = pos.y+1
|
||||||
soundname="mesecons_noteblock_kick"
|
minetest.sound_play(soundname, {pos = pos})
|
||||||
end
|
|
||||||
if block_below_name == "default:lava_source" then
|
|
||||||
soundname="fire_large"
|
|
||||||
end
|
|
||||||
if block_below_name == "default:chest" then
|
|
||||||
soundname="mesecons_noteblock_snare"
|
|
||||||
end
|
|
||||||
if block_below_name == "default:tree" then
|
|
||||||
soundname="mesecons_noteblock_crash"
|
|
||||||
end
|
|
||||||
if block_below_name == "default:wood" then
|
|
||||||
soundname="mesecons_noteblock_litecrash"
|
|
||||||
end
|
|
||||||
if block_below_name == "default:coalblock" then
|
|
||||||
soundname="tnt_explode"
|
|
||||||
end
|
|
||||||
minetest.sound_play(soundname,
|
|
||||||
{pos = pos, gain = 1.0, max_hear_distance = 32,})
|
|
||||||
end
|
end
|
||||||
|
Binary file not shown.
Before Width: | Height: | Size: 900 B After Width: | Height: | Size: 889 B |
Loading…
Reference in New Issue
Block a user