Fix coding style of nuclear reactor

technic/machines/hv/nuclear_reactor.lua

@@ -5,29 +5,30 @@
 --
 -- The nuclear reactor core needs water and a protective shield to work.
 -- This is checked now and then and if the machine is tampered with... BOOM!
+
 local burn_ticks   = 24*60                      -- [minutes]. How many minutes does the power plant burn per serving?
 local power_supply = 10000                      -- [HV] EUs
-local fuel_type    = "technic:enriched_uranium" -- This reactor burns this stuff
+local fuel_type    = "technic:enriched_uranium" -- The reactor burns this stuff
+
 
 -- FIXME: recipe must make more sense like a rod recepticle, steam chamber, HV generator?
-minetest.register_craft(
-   {output = 'technic:hv_nuclear_reactor_core',
+minetest.register_craft({
+	output = 'technic:hv_nuclear_reactor_core',
 	recipe = {
 		{'technic:stainless_steel_ingot', 'technic:stainless_steel_ingot', 'technic:stainless_steel_ingot'},
 		{'technic:stainless_steel_ingot',                              '', 'technic:stainless_steel_ingot'},
 		{'technic:stainless_steel_ingot',              'technic:hv_cable', 'technic:stainless_steel_ingot'},
 	}
- })
+})
 
-minetest.register_craftitem(
-   "technic:hv_nuclear_reactor_core",
-   {description = "Uranium Rod Driven HV Reactor",
+minetest.register_craftitem("technic:hv_nuclear_reactor_core",{
+	description = "Uranium Rod Driven HV Reactor",
 	stack_max = 1,
- }) 
+}) 
 
 local generator_formspec =
 	"invsize[8,9;]"..
-   --	"image[0,0;5,5;technic_generator_menu.png]"..
+	--"image[0,0;5,5;technic_generator_menu.png]"..
 	"label[0,0;Nuclear Reactor Rod Compartment]"..
 	"list[current_name;src;2,1;3,2;]"..
 	"list[current_player;main;0,5;8,4;]"
@@ -52,14 +53,12 @@ local nodebox = {
 	{ -0.303, -0.303, -0.397, 0.303, 0.303, 0.397 },
 }
 
-minetest.register_node(
-   "technic:hv_nuclear_reactor_core",
-   {description = "Nuclear Reactor",
+minetest.register_node("technic:hv_nuclear_reactor_core", {
+	description = "Nuclear Reactor",
 	tiles = {"technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png",
 	         "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png",
 	         "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png"},
-    --      paramtype2 = "facedir",
-    groups = {snappy=2,choppy=2,oddly_breakable_by_hand=2},
+	groups = {snappy=2, choppy=2, oddly_breakable_by_hand=2},
 	legacy_facedir_simple = true,
 	sounds = default.node_sound_wood_defaults(),
 	drawtype="nodebox",
@@ -89,15 +88,14 @@ minetest.register_node(
 			return true
 		end
 	end,
- })
+})
 
-minetest.register_node(
-   "technic:hv_nuclear_reactor_core_active",
-   {description = "Uranium Rod Driven HV Reactor",
-    tiles = {"technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png",
-	     "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png"},
-    --      paramtype2 = "facedir",
-    groups = {snappy=2,choppy=2,oddly_breakable_by_hand=2,not_in_creative_inventory=1},
+minetest.register_node("technic:hv_nuclear_reactor_core_active", {
+	description = "Uranium Rod Driven HV Reactor",
+	tiles = {"technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png",
+	         "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png",
+		 "technic_hv_nuclear_reactor_core.png", "technic_hv_nuclear_reactor_core.png"},
+	groups = {snappy=2, choppy=2, oddly_breakable_by_hand=2, not_in_creative_inventory=1},
 	legacy_facedir_simple = true,
 	sounds = default.node_sound_wood_defaults(),
 	drop="technic:hv_nuclear_reactor_core",
@@ -118,7 +116,7 @@ minetest.register_node(
 			return true
 		end
 	end,
- })
+})
 
 local check_reactor_structure = function(pos)
 	-- The reactor consists of an 11x11x11 cube structure
@@ -134,74 +132,81 @@ local check_reactor_structure = function(pos)
 	--  CCSSS|SSSCC
 	--  CCCCC|CCCCC
 	--  C = Concrete, S = Stainless Steel, W = water node (not floating), #=reactor core, |=HV cable
-				   --  The man-hole and the HV cable is only in the middle.
-				   local water_nodes = minetest.find_nodes_in_area({x=pos.x-1, y=pos.y-1, z=pos.z-1},
+	--  The man-hole and the HV cable is only in the middle
+	--  The man-hole is optional
+
+	local source_water_nodes = minetest.find_nodes_in_area(
+		{x=pos.x-1, y=pos.y-1, z=pos.z-1},
 		{x=pos.x+1, y=pos.y+1, z=pos.z+1},
 		"default:water_source")
-				   --print("Water      (  25):"..#water_nodes)
-				   if #water_nodes ~= 25 then
-				      --print("Water supply defect")
-				      return 0
+	local flowing_water_nodes = minetest.find_nodes_in_area(
+		{x=pos.x-1, y=pos.y-1, z=pos.z-1},
+		{x=pos.x+1, y=pos.y+1, z=pos.z+1},
+		"default:water_flowing")
+	if not ((#source_water_nodes + #flowing_water_nodes) >= 25) then
+		return false
 	end
-				   local inner_shield_nodes = minetest.find_nodes_in_area({x=pos.x-2, y=pos.y-2, z=pos.z-2},
+
+	local inner_shield_nodes = minetest.find_nodes_in_area(
+		{x=pos.x-2, y=pos.y-2, z=pos.z-2},
 		{x=pos.x+2, y=pos.y+2, z=pos.z+2},
 		"technic:concrete")
-
-				   --print("Concrete 1 (  96):"..#inner_shield_nodes)
-				   if #inner_shield_nodes ~= 96 then
-				      --print("Inner shield defect")
-				      return 0
+	if not (#inner_shield_nodes >= 96) then
+		return false
 	end
-				   local steel_shield_nodes = minetest.find_nodes_in_area({x=pos.x-3, y=pos.y-3, z=pos.z-3},
+
+	local steel_shield_nodes = minetest.find_nodes_in_area(
+		{x=pos.x-3, y=pos.y-3, z=pos.z-3},
 		{x=pos.x+3, y=pos.y+3, z=pos.z+3},
 		"default:steelblock")
-
-				   --print("Steel      ( 216):"..#steel_shield_nodes)
-				   if #steel_shield_nodes ~= 216 then
-				      --print("Steel shield defect")
-				      return 0
+	if not (#steel_shield_nodes >= 216) then
+		return false
 	end
-				   local outer_shield_nodes = minetest.find_nodes_in_area({x=pos.x-5, y=pos.y-5, z=pos.z-5},
+
+	local outer_shield_nodes = minetest.find_nodes_in_area(
+		{x=pos.x-5, y=pos.y-5, z=pos.z-5},
 		{x=pos.x+5, y=pos.y+5, z=pos.z+5},
 		"technic:concrete")
-				   --print("Concrete 2 (1080):"..#outer_shield_nodes)
-				   if #outer_shield_nodes ~= (984+#inner_shield_nodes) then
-				      --print("Outer shield defect")
-				      return 0
-				   end
-				   return 1
+	if not (#outer_shield_nodes >= (984 + #inner_shield_nodes)) then
+		return false
 	end
+	return true
+end
 
 local explode_reactor = function(pos)
 	print("BOOM A reactor exploded!")
-			end
+end
 
-minetest.register_abm(
-   {nodenames = {"technic:hv_nuclear_reactor_core","technic:hv_nuclear_reactor_core_active"},
+minetest.register_abm({
+	nodenames = {"technic:hv_nuclear_reactor_core", "technic:hv_nuclear_reactor_core_active"},
 	interval = 1,
 	chance   = 1,
 	action = function(pos, node, active_object_count, active_object_count_wider)
 		local meta = minetest.env:get_meta(pos)
-		local burn_time= meta:get_int("burn_time")
+		local burn_time = meta:get_int("burn_time")
 
 		-- If more to burn and the energy produced was used: produce some more
-		if burn_time>0 then
+		if burn_time > 0 then
+			if not check_reactor_structure(pos) then
+				explode_reactor(pos)
+			end
 			if meta:get_int("HV_EU_supply") == 0 then
 				-- We did not use the power
-		      meta:set_int("HV_EU_supply", power_sypply)
+				meta:set_int("HV_EU_supply", power_supply)
 			else
 				burn_time = burn_time - 1
-		      meta:set_int("burn_time",burn_time)
-		      meta:set_string("infotext", "Nuclear Reactor Core ("..math.floor(burn_time/(burn_ticks*60)*100).."%)")
+				meta:set_int("burn_time", burn_time)
+				local percent = math.floor(burn_time / (burn_ticks * 60) * 100)
+				meta:set_string("infotext", "Nuclear Reactor Core ("..percent.."%)")
 			end
 		end
 
 		-- Burn another piece of coal
-		if burn_time==0 then
+		if burn_time <= 0 then
 			local inv = meta:get_inventory()
 			local correct_fuel_count = 0
-		   if inv:is_empty("src") == false  then 
-		      local srclist= inv:get_list("src")
+			if not inv:is_empty("src") then 
+				local srclist = inv:get_list("src")
 				for _, srcstack in pairs(srclist) do
 					if srcstack then
 						local src_item=srcstack:to_table()
@@ -212,18 +217,15 @@ minetest.register_abm(
 				end
 				-- Check that the reactor is complete as well as the correct number of correct fuel
 				if correct_fuel_count == 6 then
-			 if check_reactor_structure(pos) == 1 then
-			    burn_time=burn_ticks*60
-			    meta:set_int("burn_time",burn_time)
+					if not check_reactor_structure(pos) then
+						burn_time = burn_ticks * 60
+						meta:set_int("burn_time", burn_time)
 						hacky_swap_node (pos,"technic:hv_nuclear_reactor_core_active") 
 						meta:set_int("HV_EU_supply", power_supply)
 						for idx, srcstack in pairs(srclist) do
 							srcstack:take_item()
 							inv:set_stack("src", idx, srcstack)
 						end
-			 else
-			    -- BOOM!!! (the reactor was compromised and it should explode after some time) TNT mod inspired??
-			    explode_reactor(pos)
 					end
 				else
 					meta:set_int("HV_EU_supply", 0)
@@ -232,12 +234,12 @@ minetest.register_abm(
 		end
 
 		-- Nothing left to burn
-		if burn_time==0 then
+		if burn_time == 0 then
 			meta:set_string("infotext", "Nuclear Reactor Core (idle)")
-		   hacky_swap_node (pos,"technic:hv_nuclear_reactor_core")
+			hacky_swap_node(pos,"technic:hv_nuclear_reactor_core")
 		end
 	end
- })
+})
 
 technic.register_HV_machine ("technic:hv_nuclear_reactor_core","PR")
 technic.register_HV_machine ("technic:hv_nuclear_reactor_core_active","PR")