Fix unified inventory killer

.github/workflows/integration-test.yml

@@ -1,14 +0,0 @@
-name: integration-test
-
-on: [push]
-
-jobs:
-  build:
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v1
-
-    - name: integration-test
-      run: ./integration-test.sh

.github/workflows/luacheck.yml

@@ -1,17 +0,0 @@
-name: luacheck
-
-on: [push]
-
-jobs:
-  build:
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v1
-    - name: apt
-      run: sudo apt-get install -y luarocks
-    - name: luacheck install
-      run: luarocks install --local luacheck
-    - name: luacheck run
-      run: $HOME/.luarocks/bin/luacheck ./

.luacheckrc

@@ -1,34 +0,0 @@
-
-unused_args = false
-
-globals = {
-	"wieldview",
-	"armor",
-	"armor_i18n",
-	"inventory_plus"
-}
-
-read_globals = {
-	-- Stdlib
-	string = {fields = {"split"}},
-	table = {fields = {"copy", "getn"}},
-
-	-- Minetest
-	"vector", "ItemStack",
-	"dump", "VoxelArea",
-
-	-- deps
-	"default",
-	"minetest",
-	"unified_inventory",
-	"intllib",
-	"wardrobe",
-	"player_monoids",
-	"armor_monoid",
-	"sfinv",
-	"ARMOR_MATERIALS",
-	"ARMOR_FIRE_NODES",
-	"pova",
-	"skins",
-	"u_skins"
-}

3d_armor/api.lua

@@ -185,6 +185,7 @@ armor.set_player_armor = function(self, player)
 	local material = {count=1}
 	local preview = armor:get_preview(name)
 	local texture = "3d_armor_trans.png"
+	local textures = {}
 	local physics = {}
 	local attributes = {}
 	local levels = {}
@@ -316,8 +317,6 @@ armor.punch = function(self, player, hitter, time_from_last_punch, tool_capabili
 	if not name then
 		return
 	end
-	local set_state
-	local set_count
 	local state = 0
 	local count = 0
 	local recip = true
@@ -325,8 +324,8 @@ armor.punch = function(self, player, hitter, time_from_last_punch, tool_capabili
 	local list = armor_inv:get_list("armor")
 	for i, stack in pairs(list) do
 		if stack:get_count() == 1 then
-			local itemname = stack:get_name()
-			local use = minetest.get_item_group(itemname, "armor_use") or 0
+			local name = stack:get_name()
+			local use = minetest.get_item_group(name, "armor_use") or 0
 			local damage = use > 0
 			local def = stack:get_definition() or {}
 			if type(def.on_punched) == "function" then
@@ -374,21 +373,15 @@ armor.punch = function(self, player, hitter, time_from_last_punch, tool_capabili
 				end
 			end
 			if damage == true and hitter == "fire" then
-				damage = minetest.get_item_group(itemname, "flammable") > 0
+				damage = minetest.get_item_group(name, "flammable") > 0
 			end
 			if damage == true then
 				self:damage(player, i, stack, use)
-				set_state = self.def[name].state
-				set_count = self.def[name].count
 			end
 			state = state + stack:get_wear()
 			count = count + 1
 		end
 	end
-	if set_count and set_count ~= count then
-		state = set_state or state
-		count = set_count or count
-	end
 	self.def[name].state = state
 	self.def[name].count = count
 end
@@ -478,8 +471,7 @@ end
 armor.load_armor_inventory = function(self, player)
 	local _, inv = self:get_valid_player(player, "[load_armor_inventory]")
 	if inv then
-		local meta = player:get_meta()
-		local armor_list_string = meta:get_string("3d_armor_inventory")
+		local armor_list_string = player:get_attribute("3d_armor_inventory")
 		if armor_list_string then
 			inv:set_list("armor",
 				self:deserialize_inventory_list(armor_list_string))
@@ -491,8 +483,7 @@ end
 armor.save_armor_inventory = function(self, player)
 	local _, inv = self:get_valid_player(player, "[save_armor_inventory]")
 	if inv then
-		local meta = player:get_meta()
-		meta:set_string("3d_armor_inventory",
+		player:set_attribute("3d_armor_inventory",
 			self:serialize_inventory_list(inv:get_list("armor")))
 	end
 end
@@ -533,7 +524,7 @@ armor.drop_armor = function(pos, stack)
 	if node then
 		local obj = minetest.add_item(pos, stack)
 		if obj then
-			obj:set_velocity({x=math.random(-1, 1), y=5, z=math.random(-1, 1)})
+			obj:setvelocity({x=math.random(-1, 1), y=5, z=math.random(-1, 1)})
 		end
 	end
 end

3d_armor/armor.lua

@@ -79,19 +79,6 @@ if armor.materials.wood then
 		damage_groups = {cracky=3, snappy=2, choppy=3, crumbly=2, level=1},
 		groups = {armor_feet=1, armor_heal=0, armor_use=2000, flammable=1},
 	})
-	local wood_armor_fuel = {
-		helmet = 6,
-		chestplate = 8,
-		leggings = 7,
-		boots = 5
-	}
-	for armor, burn in pairs(wood_armor_fuel) do
-		minetest.register_craft({
-			type = "fuel",
-			recipe = "3d_armor:" .. armor .. "_wood",
-			burntime = burn,
-		})
-	end
 end
 
 if armor.materials.cactus then
@@ -123,19 +110,6 @@ if armor.materials.cactus then
 		armor_groups = {fleshy=5},
 		damage_groups = {cracky=3, snappy=3, choppy=2, crumbly=2, level=1},
 	})
-	local cactus_armor_fuel = {
-		helmet = 14,
-		chestplate = 16,
-		leggings = 15,
-		boots = 13
-	}
-	for armor, burn in pairs(cactus_armor_fuel) do
-		minetest.register_craft({
-			type = "fuel",
-			recipe = "3d_armor:" .. armor .. "_cactus",
-			burntime = burn,
-		})
-	end
 end
 
 if armor.materials.steel then

3d_armor/init.lua

@@ -15,23 +15,19 @@ local F = minetest.formspec_escape
 
 dofile(modpath.."/api.lua")
 
--- integration test
-if minetest.settings:get_bool("enable_3d_armor_integration_test") then
-        dofile(modpath.."/integration_test.lua")
-end
-
-
 -- Legacy Config Support
 
 local input = io.open(modpath.."/armor.conf", "r")
 if input then
 	dofile(modpath.."/armor.conf")
 	input:close()
+	input = nil
 end
 input = io.open(worldpath.."/armor.conf", "r")
 if input then
 	dofile(worldpath.."/armor.conf")
 	input:close()
+	input = nil
 end
 for name, _ in pairs(armor.config) do
 	local global = "ARMOR_"..name:upper()
@@ -128,8 +124,7 @@ local function validate_armor_inventory(player)
 		return
 	end
 	local armor_prev = {}
-	local attribute_meta = player:get_meta() -- I know, the function's name is weird but let it be like that. ;)
-	local armor_list_string = attribute_meta:get_string("3d_armor_inventory")
+	local armor_list_string = player:get_attribute("3d_armor_inventory")
 	if armor_list_string then
 		local armor_list = armor:deserialize_inventory_list(armor_list_string)
 		for i, stack in ipairs(armor_list) do
@@ -174,9 +169,9 @@ local function validate_armor_inventory(player)
 	end
 end
 
-local function init_player_armor(initplayer)
-	local name = initplayer:get_player_name()
-	local pos = initplayer:get_pos()
+local function init_player_armor(player)
+	local name = player:get_player_name()
+	local pos = player:get_pos()
 	if not name or not pos then
 		return false
 	end
@@ -219,20 +214,20 @@ local function init_player_armor(initplayer)
 		end,
 	}, name)
 	armor_inv:set_size("armor", 6)
-	if not armor:load_armor_inventory(initplayer) and armor.migrate_old_inventory then
-		local player_inv = initplayer:get_inventory()
+	if not armor:load_armor_inventory(player) and armor.migrate_old_inventory then
+		local player_inv = player:get_inventory()
 		player_inv:set_size("armor", 6)
 		for i=1, 6 do
 			local stack = player_inv:get_stack("armor", i)
 			armor_inv:set_stack("armor", i, stack)
 		end
-		armor:save_armor_inventory(initplayer)
+		armor:save_armor_inventory(player)
 		player_inv:set_size("armor", 0)
 	end
 	for i=1, 6 do
 		local stack = armor_inv:get_stack("armor", i)
 		if stack:get_count() > 0 then
-			armor:run_callbacks("on_equip", initplayer, i, stack)
+			armor:run_callbacks("on_equip", player, i, stack)
 		end
 	end
 	armor.def[name] = {
@@ -268,7 +263,7 @@ local function init_player_armor(initplayer)
 			end
 		end
 	end
-	armor:set_player_armor(initplayer)
+	armor:set_player_armor(player)
 	return true
 end
 
@@ -296,31 +291,24 @@ minetest.register_on_player_receive_fields(function(player, formname, fields)
 	if not name then
 		return
 	end
-  local player_name = player:get_player_name()
 	for field, _ in pairs(fields) do
 		if string.find(field, "skins_set") then
-			minetest.after(0, function()
-        local pplayer = minetest.get_player_by_name(player_name)
-        if player then
-          local skin = armor:get_player_skin(name)
-          armor.textures[name].skin = skin
-          armor:set_player_armor(pplayer)
-        end
-			end)
+			minetest.after(0, function(player)
+				local skin = armor:get_player_skin(name)
+				armor.textures[name].skin = skin
+				armor:set_player_armor(player)
+			end, player)
 		end
 	end
 end)
 
 minetest.register_on_joinplayer(function(player)
 	default.player_set_model(player, "3d_armor_character.b3d")
-  local player_name = player:get_player_name()
-
-	minetest.after(0, function()
-    local pplayer = minetest.get_player_by_name(player_name)
-		if pplayer and init_player_armor(pplayer) == false then
-			pending_players[pplayer] = 0
+	minetest.after(0, function(player)
+		if init_player_armor(player) == false then
+			pending_players[player] = 0
 		end
-	end)
+	end, player)
 end)
 
 minetest.register_on_leaveplayer(function(player)
@@ -393,9 +381,8 @@ if armor.config.punch_damage == true then
 	end)
 end
 
-minetest.register_on_player_hpchange(function(player, hp_change, reason)
-	if player and reason.type ~= "drown" and reason.hunger == nil
-			and hp_change < 0 then
+minetest.register_on_player_hpchange(function(player, hp_change)
+	if player and hp_change < 0 then
 		local name = player:get_player_name()
 		if name then
 			local heal = armor.def[name].heal
@@ -430,7 +417,7 @@ minetest.register_globalstep(function(dtime)
 	end
 end)
 
--- Fire Protection and water breathing, added by TenPlus1.
+-- Fire Protection and water breating, added by TenPlus1
 
 if armor.config.fire_protect == true then
 	-- override hot nodes so they do not hurt player anywhere but mod

3d_armor/integration_test.lua

@@ -1,25 +0,0 @@
-
-minetest.log("warning", "[TEST] integration-test enabled!")
-
-minetest.register_on_mods_loaded(function()
-	minetest.after(1, function()
-
-		local data = minetest.write_json({ success = true }, true);
-		local file = io.open(minetest.get_worldpath().."/integration_test.json", "w" );
-		if file then
-			file:write(data)
-			file:close()
-		end
-
-		file = io.open(minetest.get_worldpath().."/registered_nodes.txt", "w" );
-		if file then
-			for name in pairs(minetest.registered_nodes) do
-				file:write(name .. '\n')
-			end
-			file:close()
-		end
-
-		minetest.log("warning", "[TEST] integration tests done!")
-		minetest.request_shutdown("success")
-	end)
-end)

3d_armor/mod.conf

@@ -1,4 +0,0 @@
-name = 3d_armor
-depends = default
-optional_depends = player_monoids, armor_monoid, pova, fire, ethereal, bakedclay, intllib
-description = Adds craftable armor that is visible to other players.