Version MFF.

(one with brass handles, one chrome)

.luacheckrc

@@ -1,23 +0,0 @@
-unused_args = false
-allow_defined_top = true
-
-read_globals = {
-	"DIR_DELIM",
-	"minetest", "core",
-	"dump",
-	"vector", "nodeupdate",
-	"VoxelManip", "VoxelArea",
-	"PseudoRandom", "ItemStack",
-	"intllib",
-	"default",
-	"stairsplus",
-	"signs_lib",
-	"beds",
-	"technic",
-	"mesecon",
-}
-
-globals = {
-	"armor",
-}
-

bower.json

@@ -1,19 +0,0 @@
-{
-    "name": "homedecor_modpack",
-    "description": "This mod adds a whole bunch of new items to Minetest suitable for decorating inside and outside a home.",
-    "keywords": [
-		"building",
-		"cosmetic",
-        "homedecor modpack",
-		"homedecor_modpack"
-    ],
-    "homepage": "http://daconcepts.com/vanessa/hobbies/minetest/homedecor-crafting-guide/homedecor-craft-guide.html",
-	"project": "https://github.com/minetest-mods/homedecor_modpack",
-    "forum": "http://forum.minetest.net/viewtopic.php?f=11&t=2041",
-    "screenshots": [
-        "http://daconcepts.com/vanessa/hobbies/minetest/screenshots/homedecor1.png"
-    ],
-    "authors": [
-        "VanessaE"
-    ]
-}

building_blocks/init.lua

@@ -113,10 +113,12 @@ else
 end
 
 minetest.register_craft({
-	output = 'default:stick 4',
+	output = 'building_blocks:sticks',
 	recipe = {
-		{'building_blocks:sticks'},
-	}
+		{'group:stick', '', 'group:stick'},
+		{'', 'group:stick', ''},
+		{'group:stick', '', 'group:stick'},
+	} -- MODIFICATION MADE FOR MFF ^
 })
 
 minetest.register_craft({
@@ -518,14 +520,14 @@ minetest.register_craftitem("building_blocks:tar_base", {
 })
 
 --Tar
-minetest.register_craft({
+--[[minetest.register_craft({
 	output = 'building_blocks:knife 1',
 	recipe = {
 		{"group:tar_block"},
 		{"group:stick"},
 	}
 })
-
+--]]			-- Modif MFF, remove this useless tool
 minetest.register_alias("tar", "building_blocks:Tar")
 minetest.register_alias("fakegrass", "building_blocks:fakegrass")
 minetest.register_alias("tar_knife", "building_blocks:knife")
@@ -573,8 +575,8 @@ minetest.register_tool("building_blocks:knife", {
 	tool_capabilities = {
 		max_drop_level=0,
 		groupcaps={
-			choppy={times={[2]=7.50, [3]=2.80}, uses=100, maxlevel=1},
-			fleshy={times={[2]=5.50, [3]=2.80}, uses=100, maxlevel=1}
+			choppy={times={[2]=7.50, [3]=2.80}, uses = 100, maxlevel=1},
+			fleshy={times={[2]=5.50, [3]=2.80}, uses = 100, maxlevel=1}
 		}
 	},
 })

computer/computers.lua

@@ -29,7 +29,6 @@ minetest.register_node("computer:vanio", {
 	on_rightclick = function(pos, node, clicker, itemstack)
 		node.name = "computer:vanio_off"
 		minetest.set_node(pos, node)
-		return itemstack
 	end
 })
 
@@ -49,7 +48,6 @@ minetest.register_node("computer:vanio_off", {
 	on_rightclick = function(pos, node, clicker, itemstack)
 		node.name = "computer:vanio"
 		minetest.set_node(pos, node)
-		return itemstack
 	end
 })
 
@@ -170,7 +168,6 @@ minetest.register_node("computer:monitor", {
 	on_rightclick = function(pos, node, clicker, itemstack)
 		node.name = "computer:monitor_on"
 		minetest.set_node(pos, node)
-		return itemstack
 	end
 })
 
@@ -189,7 +186,6 @@ minetest.register_node("computer:monitor_on", {
 	on_rightclick = function(pos, node, clicker, itemstack)
 		node.name = "computer:monitor"
 		minetest.set_node(pos, node)
-		return itemstack
 	end
 })
 
@@ -298,13 +294,12 @@ minetest.register_node("computer:server", {
 	on_rightclick = function(pos, node, clicker, itemstack)
 		node.name = "computer:server_on"
 		minetest.set_node(pos, node)
-		return itemstack
 	end,
 	on_place = function(itemstack, placer, pointed_thing)
 		local pos = pointed_thing.above
 		if minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name ~= "air" then
 			minetest.chat_send_player( placer:get_player_name(), "Not enough vertical space to place a server!" )
-			return itemstack
+			return
 		end
 		return minetest.item_place(itemstack, placer, pointed_thing)
 	end
@@ -316,8 +311,8 @@ minetest.register_node("computer:server_on", {
 	tiles = {
 		'computer_server_t.png',
 		'computer_server_bt.png',
-		'computer_server_l.png',
 		'computer_server_r.png',
+		'computer_server_l.png',
 		'computer_server_bt.png',
 		'computer_server_f_on.png',
 	},
@@ -338,6 +333,5 @@ minetest.register_node("computer:server_on", {
 	on_rightclick = function(pos, node, clicker, itemstack)
 		node.name = "computer:server"
 		minetest.set_node(pos, node)
-		return itemstack
 	end
 })

computer/init.lua

@@ -2,18 +2,19 @@ computer = {}
 screwdriver = screwdriver or {}
 
 computer.register = function (name, def)
+	local nodename = name
 	if (name:sub(1, 1) == ":") then name = name:sub(2) end
 	local modname, basename = name:match("^([^:]+):(.*)")
 	local TEXPFX = modname.."_"..basename.."_"
 	local ONSTATE = modname..":"..basename
 	local OFFSTATE = modname..":"..basename.."_off"
-	local cdef = table.copy(def)
+	local def = def
 	minetest.register_node(ONSTATE, {
 		drawtype = "nodebox",
 		paramtype = "light",
 		paramtype2 = "facedir",
-		description = cdef.description,
-		inventory_image = cdef.inventory_image,
+		description = def.description,
+		inventory_image = def.inventory_image,
 		groups = {snappy=2, choppy=2, oddly_breakable_by_hand=2},
 		tiles = {
 			TEXPFX.."tp.png",
@@ -23,15 +24,14 @@ computer.register = function (name, def)
 			TEXPFX.."bk.png",
 			TEXPFX.."ft.png"
 		},
-		node_box = cdef.node_box,
-		selection_box = cdef.node_box,
+		node_box = def.node_box,
+		selection_box = def.node_box,
 		on_rightclick = function (pos, node, clicker, itemstack)
-			if cdef.on_turn_off and cdef.on_turn_off(pos, node, clicker, itemstack) then
-				return itemstack
+			if (def.on_turn_off) then
+				if (def.on_turn_off(pos, node, clicker, itemstack)) then return end
 			end
 			node.name = OFFSTATE
 			minetest.set_node(pos, node)
-			return itemstack
 		end
 	})
 	minetest.register_node(OFFSTATE, {
@@ -40,32 +40,34 @@ computer.register = function (name, def)
 		paramtype2 = "facedir",
 		groups = {snappy=2, choppy=2, oddly_breakable_by_hand=2, not_in_creative_inventory=1},
 		tiles = {
-			(TEXPFX.."tp"..(cdef.tiles_off.top    and "_off" or "")..".png"),
-			(TEXPFX.."bt"..(cdef.tiles_off.bottom and "_off" or "")..".png"),
-			(TEXPFX.."rt"..(cdef.tiles_off.right  and "_off" or "")..".png"),
-			(TEXPFX.."lt"..(cdef.tiles_off.left   and "_off" or "")..".png"),
-			(TEXPFX.."bk"..(cdef.tiles_off.back   and "_off" or "")..".png"),
-			(TEXPFX.."ft"..(cdef.tiles_off.front  and "_off" or "")..".png")
+			(TEXPFX.."tp"..(def.tiles_off.top    and "_off" or "")..".png"),
+			(TEXPFX.."bt"..(def.tiles_off.bottom and "_off" or "")..".png"),
+			(TEXPFX.."rt"..(def.tiles_off.right  and "_off" or "")..".png"),
+			(TEXPFX.."lt"..(def.tiles_off.left   and "_off" or "")..".png"),
+			(TEXPFX.."bk"..(def.tiles_off.back   and "_off" or "")..".png"),
+			(TEXPFX.."ft"..(def.tiles_off.front  and "_off" or "")..".png")
 		},
-		node_box = cdef.node_box_off or cdef.node_box,
-		selection_box = cdef.node_box_off or cdef.node_box,
+		node_box = def.node_box_off or def.node_box,
+		selection_box = def.node_box_off or def.node_box,
 		on_rightclick = function (pos, node, clicker, itemstack)
-			if cdef.on_turn_on and cdef.on_turn_on(pos, node, clicker, itemstack) then
-				return itemstack
+			if (def.on_turn_on) then
+				if (def.on_turn_on(pos, node, clicker, itemstack)) then return end
 			end
 			node.name = ONSTATE
 			minetest.set_node(pos, node)
-			return itemstack
 		end,
 		drop = ONSTATE
 	})
 end
 
 computer.register_handheld = function (name, def)
+	local nodename = name
 	if (name:sub(1, 1) == ":") then name = name:sub(2) end
 	local modname, basename = name:match("^([^:]+):(.*)")
 	local TEXPFX = modname.."_"..basename.."_inv"
 	local ONSTATE = modname..":"..basename
+	local OFFSTATE = modname..":"..basename.."_off"
+	local on_use = def.on_use
 	minetest.register_craftitem(ONSTATE, {
 		description = def.description,
 		inventory_image = TEXPFX..".png",
@@ -75,7 +77,8 @@ end
 
 computer.pixelnodebox = function (size, boxes)
 	local fixed = { }
-	for _, box in ipairs(boxes) do
+	local i, box
+	for i, box in ipairs(boxes) do
 		local x, y, z, w, h, l = unpack(box)
 		fixed[#fixed + 1] = {
 			(x / size) - 0.5,

computer/tetris.lua

@@ -71,7 +71,7 @@ local function step(pos, fields)
 	local meta = minetest.get_meta(pos)
 	local t = minetest.deserialize(meta:get_string("tetris"))
 
-	local function new_game(p)
+	local function new_game(pos)
 		local nex = math.random(7)
 
 		t = {
@@ -84,7 +84,7 @@ local function step(pos, fields)
 			x=4, y=0, rot=1
 		}
 
-		local timer = minetest.get_node_timer(p)
+		local timer = minetest.get_node_timer(pos)
 		timer:set(0.3, 0)
 	end
 
@@ -270,14 +270,9 @@ minetest.register_node("computer:tetris_arcade", {
 	end,
 	on_place = function(itemstack, placer, pointed_thing)
 		local pos = pointed_thing.above
-		if minetest.is_protected(pos, placer:get_player_name()) or
-			minetest.is_protected({x=pos.x, y=pos.y+1, z=pos.z}, placer:get_player_name()) then
-			return itemstack
-		end
 		if minetest.get_node({x=pos.x, y=pos.y+1, z=pos.z}).name ~= "air" then
 			minetest.chat_send_player(placer:get_player_name(), "No room for place the Arcade!")
-			return itemstack
-		end
+		return end
 		local dir = placer:get_look_dir()
 		local node = {name="computer:tetris_arcade", param1=0, param2 = minetest.dir_to_facedir(dir)}
 		minetest.set_node(pos, node)