6 Commits

Author SHA1 Message Date
01da3bf0b1 Change License 2023-07-15 12:45:37 +02:00
e575714eba Old code removal
Logging the loading time is not needed since Minetest writes it to the info log now.
2023-07-15 12:45:20 +02:00
c12542270b Add .luacheckrc for code linting 2023-07-15 12:44:00 +02:00
35da02ed5f Sound changes: Use a lower pitch for the big chest
I haven't changed the pitch for default_chest_locked since the sound seems to emanate from the lock and is thus unrelated to the chest size.
Additional, hardly-noticeable changes: Enable ephemeral as recommended and reduce the default_chest_close gain.
2023-07-15 12:13:55 +02:00
02f3589c7a Replace the depends.txt with a mod.conf 2021-03-11 13:58:45 +01:00
f34f3b7724 Localise "node" 2020-10-18 00:00:25 +02:00
5 changed files with 13 additions and 28 deletions

2
.luacheckrc Normal file
View File

@ -0,0 +1,2 @@
read_globals = {"minetest", "table", "default", "pipeworks"}
globals = {"connected_chests"}

View File

@ -1,2 +1,2 @@
connected_chest_open from default
rest WTFPL
Content which is not copied from minetest_game is licensed under MIT.

View File

@ -1,3 +0,0 @@
default
pipeworks?
technic?

View File

@ -1,6 +1,3 @@
local load_time_start = minetest.get_us_time()
-- param_tab maps the x and z offset to a param2 value
local param_tab = {
["-1 0"] = 0,
@ -279,7 +276,7 @@ function connected_chests.register_chest(fromname, data)
}
def_opened.diggable = false
def_opened.on_blast = function() end
inside_texture = "default_chest_inside.png^([combine:16x32:5,0=" ..
inside_texture = "default_chest_inside.png^([combine:16x32:5,0=" ..
"default_chest_inside.png^connected_chests_inside_frame.png^[" ..
"makealpha:255,126,126)"
-- TODO, see right chest
@ -475,7 +472,7 @@ local function close_chest(vi)
pos.x = pos.x + x * 0.5
pos.z = pos.z + z * 0.5
minetest.sound_play("default_chest_close",
{gain = 10.3, pos = pos, max_hear_distance = 10})
{gain = 0.3, pos = pos, max_hear_distance = 10, pitch = 0.7}, true)
end
-- close all remaining open chest on shutdown
@ -521,7 +518,7 @@ connected_chests.register_chest("default:chest", {
add_open_chest = true,
on_rightclick = function(pos, _, player)
minetest.sound_play("default_chest_open",
{gain = 0.3, pos = pos, max_hear_distance = 10})
{gain = 0.3, pos = pos, max_hear_distance = 10, pitch = 0.7}, true)
local vi = minetest.hash_node_position(pos)
if not open_chests[vi]
@ -531,7 +528,7 @@ connected_chests.register_chest("default:chest", {
-- TODO: test for invalid param2 values
local x, z = unpack(param_tab2[left_param2])
local pos_right = {x=pos.x-x, y=pos.y, z=pos.z-z}
node = minetest.get_node(pos_right)
local node = minetest.get_node(pos_right)
if node.name == "default:chest_connected_right"
and not chest_lid_obstructed(pos_right) then
minetest.swap_node(pos, {
@ -563,12 +560,12 @@ connected_chests.register_chest("default:chest_locked", {
add_open_chest = true,
on_rightclick = function(pos, _, player)
if not default.can_interact_with_node(player, pos) then
minetest.sound_play("default_chest_locked", {pos = pos})
minetest.sound_play("default_chest_locked", {pos = pos}, true)
return
end
minetest.sound_play("default_chest_open",
{gain = 0.32, pos = pos, max_hear_distance = 10})
{gain = 0.32, pos = pos, max_hear_distance = 10, pitch = 0.7}, true)
local vi = minetest.hash_node_position(pos)
-- TODO: somehow avoid using the chest node names here
@ -579,7 +576,7 @@ connected_chests.register_chest("default:chest_locked", {
-- TODO: test for invalid param2 values
local x, z = unpack(param_tab2[left_param2])
local pos_right = {x=pos.x-x, y=pos.y, z=pos.z-z}
node = minetest.get_node(pos_right)
local node = minetest.get_node(pos_right)
if node.name == "default:chest_locked_connected_right"
and not chest_lid_obstructed(pos_right) then
minetest.swap_node(pos_right, {
@ -638,17 +635,3 @@ minetest.register_alias("connected_chests:chest_left_locked", "default:chest_loc
minetest.register_alias("connected_chests:chest_right_locked", "default:chest_locked_connected_right")
minetest.register_alias("connected_chests:chest_locked_left", "default:chest_locked_connected_left")
minetest.register_alias("connected_chests:chest_locked_right", "default:chest_locked_connected_right")
--~ local function log_access(pos, player, text)
--~ minetest.log("action", player:get_player_name()..
--~ " moves stuff "..text.." at "..minetest.pos_to_string(pos))
--~ end
local time = (minetest.get_us_time() - load_time_start) / 1000000
local msg = "[connected_chests] loaded after ca. " .. time .. " seconds."
if time > 0.01 then
print(msg)
else
minetest.log("info", msg)
end

3
mod.conf Normal file
View File

@ -0,0 +1,3 @@
name = connected_chests
depends = default
optional_depends = pipeworks,technic