When pressed mouse was moved over an item before releasing the mouse button it was sending immediately EGET_LISTBOX_SELECTED_AGAIN instead of expected EGET_LISTBOX_CHANGED (mouse move changes do not send any events).
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6454 dfc29bdd-3216-0410-991c-e03cc46cb475
Not quite sure why it was done that way. Maybe to ensure we work with byte-pointers of correct size or something?
Anyway, this doesn't seem to be defined in c++, so let's try working with a cast instead.
Just something cppcheck tool complained about.
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6447 dfc29bdd-3216-0410-991c-e03cc46cb475
Found by clang analyser. Not sure if it could really ever have happened, but won't hurt to fix
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6443 dfc29bdd-3216-0410-991c-e03cc46cb475
This is based on bugreport #458 reported by viwrap who also made a nice test-case model.
Note: While solution seems to work and would even be faster, I'm not 100% sure yet if there are no downsides.
The other solution seems to regard last column in matrices - thought I don't think we ever set or use that.
And I also haven't found out yet _why_ the original solution goes wrong.
But animation system uses right-hand quaternions unlike rest of Irrlicht which is obviously a bit dangerous, will have to check the conversions some day.
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6438 dfc29bdd-3216-0410-991c-e03cc46cb475
It still won't work yet for scaled boundingboxes (or parents being scaled).
But at least it's now large enough for typical unscaled boundingboxes.
Before it was always too small - even for the simplest quadratic billboard case seen without rotation.
Now it's always a bit too large, but that's way less of a problem (collisions still work and culling simply happens a bit less often, but not too often which is way worse)
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6431 dfc29bdd-3216-0410-991c-e03cc46cb475
Lots of places where coders did not realize our Printer::log with hint adds a ": " string between message and hint
Which caused uglier messages in a few places (added documentation for that, maybe helps?)
Some added info in a few places
Some whitespace unification
Some spelling unification
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6414 dfc29bdd-3216-0410-991c-e03cc46cb475
Other functions like getMaterialRendererName got switched to u32 in the past. I can see no reason why this one was left out, so changing it to be same as the rest.
git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6300 dfc29bdd-3216-0410-991c-e03cc46cb475
Fix mistake on github
Comply with changes 1
Comply with requested changes 2
Comply with requested changed 3
Comply with requested changed 4
Requested changed 5
Requested changed 6
Requested changed 7
Requested changed 8
Requested changed 9
Requested changed 10
Requested changes 11
Requested changes 12
This one wasn't even requested
I just turned on my vertical ruler and I'm going to go nuts
Line 81 doesn't exist anymore
Requested changes 13
Requested changes 14
Begin snow man test
Write a lot of tests for snow man
Add to git ignore
Now unignore it
Alphabetical order
Pass by reference
Pass by reference
vertexBuffer is now handled on stack
Preallocate indicesBuffer then reverse it when complete
Undo vertexBuffer stack change causing mac builds to fail
Use direct initialization on the vertexBuffer
Fix embedded textures causing a model not to load
Add todo
Add another todo
Push current (broken) prototyping
Fix missing bracket
Make a single array object work
Convert hard array into dynamic vector
Simplify semantics
Remove "new"
Add blocker for vscode environment changes
Disable non-dynamic prototyping
Add comment
Add more informative debug & disable it
Add additional items to gitignore
Add debug info for scalar value
Output even more debug info
Make textures render correctly
Insert the indices properly
Update .gitignore
Disable y flip
Make a reusable vertex buffer :)
Disallow embedded textures
More disable
Set up implementation for contiguous model
Add a note
More automation & framework
Final framework before stepping into function overhaul
Hold track of current_index
Integrate iterators
More integration
Rename, it's going to need 2 counters
Correctly offset the count to the right
Sync normals with positions
Time to use a tuple
Set up other counters
Do return value
Do input passing
Make (somewhat) working contiguous model
Add getter for translation data
Add debug info for future utilization
Update .gitignore
More debug
Update .gitignore
Update .gitignore
Remove all debug info & clean up
Delete this thing
Automate everything & put it into spec
Spaces into tabs
Remove array include as build test
Fix the gitignore
The commit also establishes a precedent of leaving off the `virtual`
keyword in overrides. Although not strictly necessary, I believe this is
good for readability because it makes it clear it is an override and not
a pure virtual function, and it helps keep line lengths shorter. We
should move towards eliminating the macro altogether, but the definition
has been left in with a note on deprecation so that in-progress work
will not suffer merge conflicts.
